Add api_version to constructors #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
reviewed
Aug 23, 2023
kkraus14
reviewed
Aug 24, 2023
| @@ -80,7 +80,7 @@ def column_from_sequence(sequence: Sequence[Any], *, dtype: Any, name: str = '', | |||
| api_version: str | None | |||
| A string representing the version of the dataframe API specification | |||
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |||
There was a problem hiding this comment.
Suggested change
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |
| in ``'YYYY.MM'`` form, for example, ``'2023.04'``. |
kkraus14
reviewed
Aug 24, 2023
| @@ -104,7 +104,7 @@ def dataframe_from_dict(data: Mapping[str, Column[Any]], *, api_version: str | N | |||
| api_version: str | None | |||
| A string representing the version of the dataframe API specification | |||
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |||
There was a problem hiding this comment.
Suggested change
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |
| in ``'YYYY.MM'`` form, for example, ``'2023.04'``. |
kkraus14
reviewed
Aug 24, 2023
| @@ -144,7 +144,7 @@ def column_from_1d_array(array: Any, *, dtype: Any, name: str = '', api_version: | |||
| api_version: str | None | |||
| A string representing the version of the dataframe API specification | |||
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |||
There was a problem hiding this comment.
Suggested change
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |
| in ``'YYYY.MM'`` form, for example, ``'2023.04'``. |
kkraus14
reviewed
Aug 24, 2023
| @@ -176,7 +176,7 @@ def dataframe_from_2d_array(array: Any, *, names: Sequence[str], dtypes: Mapping | |||
| api_version: str | None | |||
| A string representing the version of the dataframe API specification | |||
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |||
There was a problem hiding this comment.
Suggested change
| to be returned, in ``'YYYY.MM'`` form, for example, ``'2023.04'``. | |
| in ``'YYYY.MM'`` form, for example, ``'2023.04'``. |
kkraus14
approved these changes
Aug 29, 2023
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.