Skip to content

add column.rename #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

MarcoGorelli
Copy link
Contributor

columns can have names, so they probably need a rename method to change it?

@rgommers
Copy link
Member

rgommers commented Aug 2, 2023

Should this explicitly say that this returns a new column that's not contained in any dataframe? I imagine a lot of folks are going to assume it's an in-place change, which cannot really work.

@MarcoGorelli MarcoGorelli merged commit adf2fe4 into data-apis:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants