Skip to content

add an __invert__ method to DataFrame #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Conversation

MarcoGorelli
Copy link
Contributor

as discussed on the call

@jbrockmendel
Copy link
Contributor

does __invert__ raise on non-boolean dtypes? xref pandas-dev/pandas#51567

@MarcoGorelli
Copy link
Contributor Author

yeah it should do. quite a few of these should raise in such cases (e.g. any, all)

@rgommers
Copy link
Member

Can you add that it must raise an exception on all dtypes except bool Marco, and resolve the merge conflict? Then this looks good to go.

@MarcoGorelli
Copy link
Contributor Author

sure, done (and added a similar docstring to any and all)

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@rgommers
Copy link
Member

Everyone seems happy and no more comments, so in it goes. Thanks @MarcoGorelli & reviewers.

@rgommers rgommers changed the title add __invert__ add an __invert__ method to DataFrame Apr 13, 2023
@rgommers rgommers merged commit f527136 into data-apis:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants