-
Notifications
You must be signed in to change notification settings - Fork 21
Add rename columns and get column names #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rename columns and get column names #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks @MarcoGorelli. One question: do we expect/allow users to mutate the returned list? If not, a tuple of strings may be nicer (can return an existing tuple perhaps, a list must be copied) and may be slightly nicer for a JIT compiler.
yup, sounds good, have updated |
A bit more discussion on the return type:
|
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. Let's give this a go - thanks @MarcoGorelli and @kkraus14!
closes #105
Doesn't look like there's objections, so I went ahead and opened this