-
Notifications
You must be signed in to change notification settings - Fork 53
Specify output array data types #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks like a good idea to me. |
This looks good to me too. For the "either float32 or float64" cases, should we require any kind of consistency, e.g., an array library always has a "default float dtype" that is used in these cases? Also, should it at least require the same float dtype when the argument(s) themselves promote to a float dtype (e.g., |
Yes, I believe I suggested that somewhere as well. That would also cut down on repeated content.
I think that's already covered by type promotion rules, no need to spell that out. |
@rgommers This PR (and OP) have been updated. Should be ready for formal review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kgryte, this is pretty comprehensive, overall looks good. A couple of small issues.
Addressed feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, merging. Thanks @kgryte!
This PR
Notes
counts
fromunique
.