Skip to content

Add specifications for constants and associated element-wise functions #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 16, 2020

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Sep 14, 2020

This PR

  • adds specifications for constants and associated element-wise functions.
  • is derived from comparing API signatures across array libraries.

Notes

  • Seems as though most libraries rely on NumPy for constants.
  • This PR omits the euler_gamma constant, as it is rarely used according to record data.
  • This PR includes one and only one alias for inf and nan.
  • This PR does not include aliases for +0 and -0. The record data does not show their use.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Constants like inf are not universally implemented, but are heavily used and it's quite weird that there are libraries that prefer users to spell that as float('Inf') instead.

@rgommers
Copy link
Member

This is very straightforward, merging. Thanks @kgryte

@rgommers rgommers merged commit c4ab9fe into master Sep 16, 2020
@rgommers rgommers deleted the constants branch September 16, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants