Update guidance for unsigned integer data types for sum
and prod
#340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
sum
andprod
whenx
has an unsigned integer data type with a smaller range of values than the default integer data type and thedtype
kwarg isNone
. Namely, when providing auint8
array, the returned array should have auint32
data type when the default integer data type isint32
. This is in contrast to current guidance which requires that the returned array have anint32
data type. In short, the returned array should have a data type whose "signedness" matches the input array. Returning a signed integer array when providing an unsigned integer array is likely to violate user expectations.The changes introduced in this PR match NumPy's current behavior.