Changes Implementation section of data-interchange to close #337 #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement of DLManagedTensor passed via Python capsule
fschlimb
reviewed
Nov 17, 2021
Comment on lines
+150
to
+157
| The consumer must transer ownership of the `DLManangedTensor` from the | ||
| capsule to its own object. It does so by renaming the capsule to | ||
| `"used_dltensor"` to ensure that `PyCapsule_Destructor` will not get | ||
| called (ensured if `PyCapsule_Destructor` calls `deleter` only for | ||
| capsules whose name is `"dltensor"`), but the `deleter` of the | ||
| `DLManagedTensor` will be called by the destructor of the consumer | ||
| library object created to own the `DLManagerTensor` obtained from the | ||
| capsule. |
There was a problem hiding this comment.
Why is the ref-count of the capsule not enough?
There was a problem hiding this comment.
My understanding is because it is an interlibrary data exchange protocol, and if some libraries transfer ownership to their internal objects in their existing implementations, discrepancy in lifetime management approaches may result in double free.
leofang
approved these changes
Nov 18, 2021
|
Thanks for reviewing @leofang! Will merge. If anything further needs updating, we can address in a follow-up PR. Thanks, @oleksandr-pavlyk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the implementation section of
data_interchange.mdper #337.@fschlimb