-
Notifications
You must be signed in to change notification settings - Fork 53
Special case when NaNs present in statistical functions #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't see that in the example. |
Oops I was thinking of a different discussion—I didn't even read my own example! PR description updated accordingly. |
@kgryte I suppose this special case applies to all statistical functions? If that's the case, I can update this PR. |
@honno Yes, that is correct. |
294301d
to
b836124
Compare
min()
and max()
This commit brings the formatting and language in-line with element-wise and array object methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @honno!
Adds a special case for the two functions that any NaNs present in computed elements should result in NaN. Hopefully I've used the correct language here.
Per discussion with @kgryte, this is expected behaviour.