Skip to content

Update the description of the entry point in purpose and scope #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2021
Merged

Update the description of the entry point in purpose and scope #327

merged 2 commits into from
Nov 9, 2021

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Nov 9, 2021

Make it clearer this is optional, and why one would want to implement/use an entry point.

Also break some long lines.

@rgommers
Update the description of the entry point in purpose and scope
b23ba06 
Make it clearer this is optional, and why one would want to
implement/use an entry point.
@rgommers rgommers added the Narrative Content Narrative documentation content. label Nov 9, 2021
@rgommers rgommers requested review from kgryte and honno November 9, 2021 20:35
honno
honno reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one snag, otherwise I like your changes.

@kgryte kgryte added this to the v2021 milestone Nov 9, 2021
@kgryte @honno
Update copy
bda92a4 
Co-authored-by: Matthew Barber <quitesimplymatt@gmail.com>
kgryte
kgryte approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte
Copy link
Contributor

kgryte commented Nov 9, 2021

Thanks, @rgommers!

@kgryte kgryte merged commit ba1ffe7 into data-apis:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno left review comments

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.
3 participants
@rgommers @kgryte @honno