Skip to content

Remove obsolete note #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Remove obsolete note #306

merged 1 commit into from
Nov 4, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 4, 2021

This PR

  • removes an obsolete note concerning adoption. The note referenced NEP 37; however, that proposal has not seen the requisite movement necessary to change either the specification's use of __array_namespace__ or the experimental implementation in NumPy. Accordingly, this PR chooses to remove the note to avoid creating any uncertainty regarding the preferred mechanism of exposing a conforming array implementation as a separate namespace.

cc @rgommers for visibility.

@kgryte kgryte added the Maintenance Bug fix, typo fix, or general maintenance. label Nov 4, 2021
@kgryte kgryte added this to the v2021 milestone Nov 4, 2021
@kgryte
Copy link
Contributor Author

kgryte commented Nov 4, 2021

Will merge. If further changes are necessary, they can be made in follow-up PRs.

@kgryte kgryte merged commit 69430af into main Nov 4, 2021
@kgryte kgryte deleted the remove-adoption-aside branch November 4, 2021 08:32
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with removal. NEP 37 was useful inspiration, but it never went anywhere so there's no point in referencing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants