Skip to content

Add note concerning the casting of boolean input arrays #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

Add note concerning the casting of boolean input arrays #296

merged 1 commit into from
Nov 1, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 1, 2021

This PR

  • adds a clarifying note regarding the casting of boolean input arrays. Namely, that True and False must cast to 1 and 0 numeric values, respectively, and 0 and non-zero numeric values must cast to False and True, respectively.
  • this was discussed during the consortium meeting held on 21 October 2021.

@kgryte kgryte added the Narrative Content Narrative documentation content. label Nov 1, 2021
@kgryte kgryte added this to the v2021 milestone Nov 1, 2021
@kgryte
Copy link
Contributor Author

kgryte commented Nov 1, 2021

As this was discussed during the 21 October 2021 consortium meeting, will merge.

@kgryte kgryte merged commit b9baefc into main Nov 1, 2021
@kgryte kgryte deleted the astype-bool branch November 1, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.
1 participant
@kgryte