Fix output array dtype when computing the remainder #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It stated that the return type should be floating-point, but it accepts integer inputs (and the remainder of two integers is always an integer).
kgryte
changed the title
kgryte
approved these changes
Sep 13, 2021
|
Regarding the special cases mentioned in the OP, we should open a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It stated that the return type should be floating-point, but it accepts
integer inputs (and the remainder of two integers is always an integer).
Somewhat related, I noticed that
remainderdoesn't specify any special cases, but it perhaps should specify the behavior for remainder by 0, and infinites. Also should integer remainder by 0 be unspecified?