Indicate that abs() of the minimum integer value for signed dtypes is undefined #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kgryte merged 6 commits into data-apis:main from asmeurer:abs-min-integer

Sep 20, 2021

Member

asmeurer commented Sep 1, 2021

No description provided.


          Indicate that abs() of the minimum integer value for signed dtypes is…

0e2a401

… undefined

kgryte reviewed

View reviewed changes

spec/API_specification/elementwise_functions.md Outdated Show resolved Hide resolved


          Move the abs(smallest signed integer) text into a note

f7c8d34

Member Author

asmeurer commented Sep 3, 2021

Should we add the same note for negative?

I noticed that NumPy uses -(min value) = min value (e.g., np.negative(-128, dtype=np.int8) == -128) and abs(min value) = min value. This has the properties that -x + x always equals 0, and abs(x) = -x for x < 0.

asmeurer added a commit to data-apis/array-api-tests that referenced this pull request


          Add an elementwise test for negative()

d593660

I am assuming for now that negative() is not defined for the smallest
representable negative integer for signed integer dtypes (see
data-apis/array-api#250).

Member

rgommers commented Sep 5, 2021

Should we add the same note for negative?

Seems reasonable to me.

rgommers added the Maintenance label

kgryte reviewed

View reviewed changes

spec/API_specification/elementwise_functions.md Outdated Show resolved Hide resolved


          Update copy

a0e4238

kgryte reviewed

View reviewed changes

spec/API_specification/elementwise_functions.md Outdated Show resolved Hide resolved


          Remove blank line

ec58914

kgryte reviewed

View reviewed changes

spec/API_specification/elementwise_functions.md Outdated Show resolved Hide resolved


          Update copy

f493f9d

"smallest" is ambiguous, as could mean `0` or the minimum value (e.g., `-128` for `int8`).

kgryte reviewed

View reviewed changes

spec/API_specification/elementwise_functions.md Outdated Show resolved Hide resolved


          Fix missing article

dbbc0db

kgryte approved these changes

View reviewed changes

Contributor

kgryte left a comment

LGTM.

Contributor

kgryte commented Sep 20, 2021

I'll make a separate PR for negative.

kgryte merged commit 5565ac4 into data-apis:main

This was referenced Sep 20, 2021

Add note to negative for signed integer dtype behavior #270

Merged

Add note to __abs__ concerning signed integer dtype behavior #271

Merged

kgryte added a commit that referenced this pull request


          Add note to __abs__ concerning signed integer dtype behavior (#271)

614f8c1

See also [gh-250](#250).

cr313 added a commit to cr313/test-array-api that referenced this pull request


          Add an elementwise test for negative()

997554f

I am assuming for now that negative() is not defined for the smallest
representable negative integer for signed integer dtypes (see
data-apis/array-api#250).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels