Skip to content

Require unique counts array to be default integer dtype #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2021
Merged

Require unique counts array to be default integer dtype #205

merged 1 commit into from
Jun 27, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jun 21, 2021

This PR

  • requires that the array containing unique counts be the default integer dtype. This change is consistent with guidance included elsewhere in the specification, such as for index arrays.

@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Jun 27, 2021
rgommers
rgommers approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an obvious fix, thanks @kgryte

@rgommers rgommers merged commit bf3ea77 into main Jun 27, 2021
@rgommers rgommers deleted the unique-counts-dtype branch June 27, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @rgommers