Add __array_namespace__ as a required method on the array object #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmeurer
commented
Mar 9, 2021
| @@ -362,11 +363,10 @@ standard can become final. We prefer to delay this decision, to see how | |||
| NEP 37 adoption will work out. | |||
| ``` | |||
|
|
|||
| The `xp` namespace must contain the array object and all functionality | |||
There was a problem hiding this comment.
I removed "array object" here, because the array class is not itself required to be a name in the namespace.
rgommers
approved these changes
Mar 10, 2021
leofang
requested changes
Mar 11, 2021
Co-authored-by: Leo Fang <leofang@bnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.