Skip to content

Update specification to use self in array object APIs #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2021
Merged

Update specification to use self in array object APIs #135

merged 3 commits into from
Apr 11, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Mar 8, 2021

This PR

  • Ensures conformance with PEP 8 in always using self in method argument signatures. The inclusion of self in the dunder signatures follows official Python documentation.

@kgryte
Use self and other in array object specs
7d3eb75 
This is in conformance with PEP 8.
@asmeurer
Copy link
Member

Looks like there are some links that need to be fixed. They should be using the method-__add__ and so on cross-reference names instead of the anchor names.

@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Mar 20, 2021
@rgommers rgommers mentioned this pull request Apr 11, 2021
Merged
rgommers
rgommers approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green now, merging. Thanks @kgryte

@rgommers rgommers merged commit 15889c6 into main Apr 11, 2021
@rgommers rgommers deleted the use-self branch April 11, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgryte @asmeurer @rgommers