Closed
Description
Originally discussed in #153 (comment).
In order to add complex support to sign
, we need to agree on the definition for complex numbers.
NumPy uses sqrt(z^2)/z
while an arguably more common convention is x/|x|
.
For paths forward we have 3 options:
- Use NumPy's definition.
- Use the more common convention used elsewhere (MATLAB, Julia, etc).
- Not support complex numbers in
sign
.
Questions
- If we choose (2), given NumPy's potential v2 release, would NumPy be willing to introduce this breaking change?