-
Notifications
You must be signed in to change notification settings - Fork 4
✨: create HasNamepace #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9318276
to
7ec8d29
Compare
Also, do we want to call it HasNamespace? |
7ec8d29
to
aaebe45
Compare
From the typing spec:
So I suppose |
aaebe45
to
151ea4b
Compare
83637a4
to
b6e28a6
Compare
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com> Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
b6e28a6
to
53732c8
Compare
FYI I'm a fan of squash merges, so totally feel free to do that here. |
I think I like the sound of |
SGTM |
Requires #12