Skip to content

Change hh.mutually_broadcastable_shapes() defaults to generate more interesting shapes #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

honno
Copy link
Member

@honno honno commented Jan 14, 2022

Changes the defaulting of max_dims and max_side so that more interesting shapes get generated. Also defaults min_side to 0.

@asmeurer
Copy link
Member

I guess this doesn't end up being that different for us because the hypothesis shapes strategy is also based on limiting the side length, whereas in ndindex I just use tuples(integer()) and filter across the total size.

@honno
Copy link
Member Author

honno commented Jan 17, 2022

I guess this doesn't end up being that different for us because the hypothesis shapes strategy is also based on limiting the side length, whereas in ndindex I just use tuples(integer()) and filter across the total size.

Ah so you're saying #73 is limited as-is? Does this PR fair well? Maybe can bump up the defaults a bit more too.

My impression is that the defaults from Hypothesis might be too low, but I also think relying on st.integers().filter(<below max size>) is overkill (i.e. seemingly won't be finding interesting bugs for the big performance cost when making/manipulating arrays).

@asmeurer asmeurer merged commit 00f63bb into data-apis:master Jan 17, 2022
@honno honno deleted the mbs branch February 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants