Skip to content

Indexing tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Indexing tests #57

merged 4 commits into from
Jan 6, 2022

Conversation

honno
Copy link
Member

@honno honno commented Jan 4, 2022

Should resolve #54, currently WIP.

Consolidates test_array2scalar.py with a new test_getitem method into the file test_array_object.py. test_getitem (will) completely supersede test_indexing.py, as testing the out array for any valid index implicitly covers those assertions.

@honno honno marked this pull request as ready for review January 6, 2022 13:40
@honno honno merged commit f09c939 into data-apis:master Jan 6, 2022
@honno
Copy link
Member Author

honno commented Jan 6, 2022

Also adds a test for __setitem__, which funnily enough was much easier to implement.

@honno honno deleted the reorg branch February 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve indexing coverage
1 participant