MAINT: Check essential data functions #380
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
force-pushed
the
essential-data-funcs
branch
from
1eca62a to
d53aa9f
Compare
mtsokol
force-pushed
the
essential-data-funcs
branch
from
d53aa9f to
3945aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ev-br,
As discussed in #379, here's a PR that introduces
has_setup_funcsmark.I applied it to the first batch of tests that use
.draw()calls, which underneath usesdo_draw, so at least one of theasarray,isnan,reshape,zerosis used (whichhas_setup_funcschecks).I still need to find all tests that use
draw.