Skip to content

Remove array-api-tests prefix in ID matching #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

jakevdp
Copy link
Contributor

@jakevdp jakevdp commented Aug 8, 2024

This fixes failures I'm seeing when attempting to update array-api-tests in jax-ml/jax#22903

Since the start of each skipped test name must be array_api_tests, I think this is always safe:

array-api-tests/conftest.py

Lines 159 to 161 in 31468af

if line.startswith("array_api_tests"):
id_ = line.strip("\n")
skip_ids.append(id_)

@asmeurer
Copy link
Member

asmeurer commented Aug 8, 2024

I don't quite understand why you're seeing this error, although I have seen in the past that it sometimes wants to prepend some other directory to the test name. I agree just removing it after parsing should be fine.

@asmeurer asmeurer merged commit db95e67 into data-apis:master Aug 8, 2024
4 checks passed
@jakevdp jakevdp deleted the prefix branch August 8, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants