Fix way to determine default_complex #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmeurer
reviewed
Jul 30, 2024
| @@ -322,15 +322,16 @@ def accumulation_result_dtype(x_dtype, dtype_kwarg): | |||
| default_float = xp.asarray(float()).dtype | |||
| if default_float not in real_float_dtypes: | |||
| warn(f"inferred default float is {default_float!r}, which is not a float") | |||
| if api_version > "2021.12": | |||
There was a problem hiding this comment.
I don't know about removing this. This is the check that's currently done throughout the suite to check for complex support.
Maybe we should instead make sure that ARRAY_API_TESTS_SKIP_DTYPES works correctly for complex dtypes.
There was a problem hiding this comment.
I readded the version check and added a check that no complex types are requested to be skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test suite crashes during the collection time if the implementation in question does not support complex data types. This PR changes the way in which the
default_complextype is determined to avoid the issue. Further discussion and context can be found here.