Skip to content

Add pre-commit config for pyflakes #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Add pre-commit config for pyflakes #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3209b9b
Minimal `pre-commit` config just for pyflakes
honno Oct 14, 2021
ffce706
Update lint workflow to use `pre-commit`
honno Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,5 @@ jobs:
uses: actions/setup-python@v1
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pyflakes
- name: Lint with pyfalkes
run: |
pyflakes .
- name: Run pre-commit hook
uses: pre-commit/action@v2.0.3
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
repos:
- repo: https://github.com/pycqa/flake8
rev: '4.0.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep this unpinned. Whenever pyflakes is updated it may create new failures, but those are also things we'd want to know about. Also we are going to want to add 3.10 testing pretty soon, and I don't know if this versions supports it yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I had just used the latest release tag (didn't think to unpin it, makes sense). The 4.0 release was tested for py3.10 it looks like at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to remove this? I tried removing it but that causes it to fail.

hooks:
- id: flake8
args: [--select, F]