ENH: support CuPy to_device "cpu" #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow
to_device(x, "cpu")
for CuPy--this makes it easier to write portable unit tests where theexpected value is on the host (a NumPy array)
otherwise, you can end up writing different shims in downstream libraries to move the array-like back to the host (
.get()
for CuPy...); if CuPy conforms to the standard, we shouldn't need this shim long-term