Torch linalg #33
Merged
Torch linalg #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They did not support the k keyword argument.
lezcano
reviewed
Mar 29, 2023
Comment on lines
+19
to
+20
| # Note: torch.linalg.cross does not default to axis=-1 (it defaults to the | ||
| # first axis with size 3), see https://github.com/pytorch/pytorch/issues/58743 |
There was a problem hiding this comment.
This is just in torch.cross though. torch.linalg.cross has the saner dim=-1 default.
The default for torch.cross is easily in my top 5 of craziest behaviours of PyTorch core though.
There was a problem hiding this comment.
Oh I didn't realize they were different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.