Implement isdtype() #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmeurer
commented
Mar 14, 2023
| if kind == 'bool': | ||
| return dtype == torch.bool | ||
| elif kind == 'signed integer': | ||
| return dtype in _int_dtypes and dtype.is_signed |
There was a problem hiding this comment.
Is there a better way to test if a torch dtype is integral?
There was a problem hiding this comment.
There isn't. Based on dtype properties it would be:
not dtype.is_floating_point and not dtype.is_complex and dtype.is_signed and dtype != dtype.boolwhich looks worse and may also not be foolproof. The check you have will need explicit updating if for example uint16 is added to PyTorch, but that's okay (nothing like that is in the pipeline AFAIK).
There was a problem hiding this comment.
Hopefully this function itself would be added to pytorch by then.
asmeurer
commented
Mar 14, 2023
| elif kind == 'integral': | ||
| return dtype in _int_dtypes | ||
| elif kind == 'real floating': | ||
| return dtype.is_floating_point |
There was a problem hiding this comment.
Is this the correct way to check for torch dtype categories?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
I've added some rudimentary testing here in lieu of test suite support, and also testing that the implementation works with some non-spec dtypes.