Support for downloading unsigned dev builds. #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core packages, like `webdev/dwds`, need to run tests again dev candidate releases that will be rolled into flutter. This change allows users of the CI to specify whether they want to download signed or unsigned builds. The former is what we properly call a release, the latter is a build that is only available under the `raw` folder in our cloud storage. There are two other options here: * default all dev builds to use unsigned builds. I'm not sure if this will break on non-linux systems, so we could do it only for linux for example. * define a new name `dev_unsigned` and expose it as if it existed as a channel. This would be desugared into a dev/raw request, similar to how the `main` name is desugared here. Fixes dart-lang#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core packages, like
webdev/dwds, need to run tests again dev candidatereleases that will be rolled into flutter.
This change allows users of the CI to specify whether they want to download
signed or unsigned builds. The former is what we properly call a release,
the latter is a build that is only available under the
rawfolder in ourcloud storage.
There are two other options here:
will break on non-linux systems, so we could do it only for linux for
example.
dev_unsignedand expose it as if it existed as achannel. This would be desugared into a dev/raw request, similar to
how the
mainname is desugared here.@athomas - what's a good way to test things out? Should I try to update one of our repos to use my fork and see if that works out? Also, should I include the release notes here or should that be done separately?
Fixes #29
/cc @annagrin