Remove Templates.fromContext and as a result, make code more synchronous #4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ous. Since "runtime template" support was removed, we could remove the `forceRuntimeTemplates` parameter from `Templates.fromContext`. However, the result of this is that calling `Templates.fromContext` would not need the `DartdocGeneratorOptionContext` parameter either, and is then just an alias for the `HtmlAotTemplates` constructor. So we can remove the function altogether. Since we no longer need to `await` the result of calling this function (which is now a constructor call), we can make more and more functions synchronous (see https://journal.stuffwithstuff.com/2015/02/01/what-color-is-your-function/): `bin/dartdoc.dart`'s `main`, `Dartdoc.fromContext` (which can new be a factory constructor), `initHtmlGenerator`, `buildDartdoc`, `generatorContextFromArgv`, `createPackageBuilder`. We can also remove some more code that becomes dead: `RuntimeTemplates._create`, ResourceProvider utilities, and some trivial `buildDartdoc` test helpers.
srawlins
force-pushed
the
rm-force-runtime-templates
branch
from
caa8b08 to
6156d2e
Compare
szakarias
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since "runtime template" support was removed, we could remove the
forceRuntimeTemplatesparameter fromTemplates.fromContext. However, the result of this is that callingTemplates.fromContextwould not need theDartdocGeneratorOptionContextparameter either, and is then just an alias for theHtmlAotTemplatesconstructor. So we can remove the function altogether.Since we no longer need to
awaitthe result of calling this function (which is now a constructor call), we can make more and more functions synchronous (seehttps://journal.stuffwithstuff.com/2015/02/01/what-color-is-your-function/):
bin/dartdoc.dart'smain,Dartdoc.fromContext(which can new be a factory constructor),initHtmlGenerator,buildDartdoc,generatorContextFromArgv,createPackageBuilder.We can also remove some more code that becomes dead:
RuntimeTemplates._create, ResourceProvider utilities, and some trivialbuildDartdoctest helpers.