Simplify InheritingContainer wrt inherited elements #4059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working with analyzer's InheritanceManager3, I noticed there was a fair bit of code in dartdoc's InheritingContainer that could be simplified. The `_inheritedElements` field is relied on by `inheritedMethods`, `inheritedOperators`, and `allFields`. It performs some calculations to come up with the collection of inherited elements using its own homegrown dartdoc logic, but this logic exists in the analyzer APIs on `InterfaceElement`. We can basically replace this field with access to `element.inheritedElements`. While investigating, I found that I could make a few members `@visibleForTesting`: `inheritedMethods`, `inheritedOperators`. Also `allFields` can be made private. And `Enum.hasPublicEnumValues` can be removed, as it is the same as the super implementation. This leads to all of the deleted code in `templates.runtime_renderers.dart`.
srawlins
force-pushed
the
no-inherited-elements
branch
from
276d85c to
bd4eacb
Compare
sigurdm
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with analyzer's InheritanceManager3, I noticed there was a fair bit of code in dartdoc's InheritingContainer that could be simplified. The
_inheritedElementsfield is relied on byinheritedMethods,inheritedOperators, andallFields. It performs some calculations to come up with the collection of inherited elements using its own homegrown dartdoc logic, but this logic exists in the analyzer APIs onInterfaceElement. We can basically replace this field with access toelement.inheritedElements.While investigating, I found that I could make a few members
@visibleForTesting:inheritedMethods,inheritedOperators. AlsoallFieldscan be made private. AndEnum.hasPublicEnumValuescan be removed, as it is the same as the super implementation. This leads to all of the deleted code intemplates.runtime_renderers.dart.