-
Notifications
You must be signed in to change notification settings - Fork 248
chore(pubspec): Replace shadow_dom with web_components #972
Conversation
The tests seem to fail. One possible reason is that the scripts should be added to the head section which is currently not possible with karma, see karma-runner/karma#488 |
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes #972
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes #972
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes #972
This change breaks FireFox dart2js tests. Could you look into it. |
There's also http://dartbug.com/18747 --- Angular.dart tests failing in Firefox with exactly the same errors. |
Thanks for the ref @pavelgj, I'll look at it next week |
Current status, failing on
Firefox errors are:
It does work with |
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes #972
https://code.google.com/p/dart/issues/detail?id=18747 was fixed, but we are still failing. https://travis-ci.org/angular/angular.dart/jobs/25354277 @pavelgj Is there something more that we need to do? |
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes #972
Ah, I forgot to upgrade web_components to 0.3.4 |
Here is a fun one: So, I set pubspec.yaml to be web_components >=0.3.3 and set pubspec.lock to be web_components 0.3.4
|
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes dart-archive#972
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes dart-archive#972
The shadow_dom package is deprecated, see https://code.google.com/p/dart/issues/detail?id=18080 Closes dart-archive#972
The shadow_dom package is deprecated, see
https://code.google.com/p/dart/issues/detail?id=18080
see also #956 (comment)