refactor(NgView): Make use of the ViewPort

[vicb]

This should be solving #704 however I can not get the test to work, any hint would be appreciated here (it seems to work fine in my test app).

Todo:

• uniit the test, make sure all pass,
• rewrite the commit msg (closes Routing should use ViewPort #704)

There are a few style changes in the first commit, if this is still too much, let me know but it should be pretty localized and trivial

[mhevery]

Tests pass for me. Do you still need help, or is this PR ready to go?

[vicb]

Oops hadn't seen your message about test passing. I'll try.

[vicb]

Tests still do not pass for me with the same message

    Test failed: Caught Expected: 'Foo'
      Actual: ''
       Which: is different. Both strings start the same, but the given value is missing the following trailing characters: Foo

Any help appreciated.

[mhevery]

Try:

    iit('should switch template when route is already active', async(() {
      // Force the routing system to initialize.
      _.compile('<div><ng-view></ng-view></div>');

      router.route('/foo');
      microLeap();
      Element root = _.compile('<div><ng-view></ng-view></div>');
      expect(root.text).toEqual('');

      _.rootScope.apply();
      microLeap();
      _.rootScope.apply();
      print(_.rootElement.outerHtml);
      expect(root.text).toEqual('Foo');
    }));

You need the wrapping div. This is because can not replace itself with comment node if it is top level item. It needs a container.

[vicb]

@mhevery thanks for the explanation. The PR is on the presubmit queue.

[pavelgj]

these changes have nothing to do with NgView

[vicb]

I've only removed this (because this is the default value) everywhere for consistency