This repository was archived by the owner on Feb 22, 2018. It is now read-only.
feat(css_shim): implement polyfill-unscoped-next-selector and polyfill-non-strict #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static final RegExp POLYFILL_UNSCOPED_NEXT_SELECTOR_DIRECTIVE = new RegExp( | ||
| r"polyfill-unscoped-next-selector" | ||
| r"[^}]*" | ||
| r"content\:[\s]*" |
There was a problem hiding this comment.
also : should not need to be escaped
|
LGTM with a few minor comments |
vsavkin
force-pushed
the
fix_css_shim_shadow
branch
from
c38f458 to
07a3c0b
Compare
vsavkin
force-pushed
the
fix_css_shim_shadow
branch
from
07a3c0b to
e5152d6
Compare
vsavkin
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1552