This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Revert "[#1164] move web_components line to dev_dependencies in the pu...
#1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies in the pubspec.yaml" This reverts commit 51ee50a.
|
@jbdeboer I've rebased this one. Feel free to ping me if this needs more discussion. |
|
Not yet. Since users need to include the web component Javascript tags in their apps, they should also include the dependency. However, Angular should be handling the web component tags for the apps. (e.g. if the browser is not Chrome, include platform.js). When that happens, we should be handling the dependency. |
|
Without this line they could include any version even a version that is not compatible with angular.dart. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...bspec.yaml"
This reverts commit 51ee50a.
I think the discussion is not closed on this topic, easier to discuss here than on a closed PR.
@jbdeboer @vsavkin