Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

fix(ElementBinderBuilder): throw if more than one transcluding directive... #1325

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 7, 2014

... per node

fixes #1306

@mhevery mhevery added cla: yes and removed cla: no labels Aug 7, 2014
@vicb vicb added this to the vicb-0.14 milestone Aug 13, 2014
@vicb vicb closed this in 02a5079 Aug 14, 2014
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this pull request Aug 16, 2014
@vicb vicb deleted the 0807-singleTemplate branch August 18, 2014 17:35
vicb added a commit that referenced this pull request Aug 21, 2014
@chirayuk
Copy link
Contributor

This change has been reverted in 2b0d9de.  It breaks a bunch of apps that do something like:

<foo ng-if="isEnabled" ng-repeat="item in items">

which just happens to work today.  Folks, including me, need more time to fix some large apps that break.

I've moved this onto our staging branch for early merging.

It might actually be a good idea if we can have this be split into two commits – the first one deprecating this change and the next one actually throwing the exception.  I think di and some other changes were made this way where we would throw a warning in the console (and suppress repeated warnings) in the console first and the next version would make it an error. Would you like to take on this task and write this in a more backwards friendly way?

@vicb
Copy link
Contributor Author

vicb commented Aug 22, 2014

@chirayuk check #1374, I don't think this works today (as explained in the issue linked in 1374). Then I think throwing is the right thing to do as the code is broken anyway.

@jbdeboer
Copy link
Contributor

+1 to @chirayuk's comments. Let's do this in two phases.

Also, the common use-case of <div ng-if ng-repeat> seems useful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

In Firefox combining ng-if and ng-repeat results in an empty element
4 participants