Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Added a quick fix to issue #1262 #1266

Closed
wants to merge 8 commits into from
Closed

Added a quick fix to issue #1262 #1266

wants to merge 8 commits into from

Conversation

ofagbemi
Copy link
Contributor

Better whitespace handling in toNodeList

Added a quick fix to issue #1262
66abc16 
Better whitespace handling in toNodeList
@mhevery
Copy link
Contributor

mhevery commented Jul 25, 2014

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html

@ofagbemi ofagbemi added cla: no and removed cla: yes labels Jul 25, 2014
@ofagbemi
Copy link
Contributor Author

Alright, signed! Thank you!

@vicb
Copy link
Contributor

vicb commented Jul 25, 2014

@ofagbemi the commit comment should follow the guidelines from CONTRIBUTING.md and you should also add a unit tests. Thanks.

@ofagbemi ofagbemi added cla: no and removed cla: yes labels Jul 25, 2014
@ofagbemi ofagbemi added cla: no and removed cla: yes labels Jul 29, 2014
@vicb
Copy link
Contributor

vicb commented Aug 13, 2014

@ofagbemi The commit comment should be smthg like 'feat(...): ...' and have closes #1262 in its body, could you please update it ?

@vicb vicb added this to the vicb-0.14 milestone Aug 13, 2014
Jare Fagbemi added 2 commits August 13, 2014 08:37
Revert "fix(TestBed): add whitespace handling to compile"
c2b4314 
This reverts commit 4d85bd0.
feat(TestBed): add whitespace handling to compile
1f8d0bd 
Add whitespace handling to the TestBed’s compile function.

Closes #1262. Previously, strings passed with leading or trailing
whitespace would be compiled incorrectly. Now, valid HTML with
arbitrary whitespace in and surrounding it can be compiled properly.
@ofagbemi
Copy link
Contributor Author

My apologies. Updated!

Jare Fagbemi added 2 commits August 13, 2014 08:50
Revert c2b4314..1f8d0bd
d09ca44 
This rolls back to commit c2b4314.
feat(TestBed): add whitespace handling to compile
32a0513 
Add whitespace handling to the TestBed’s compile function.

Closes #1262. Previously, strings passed with leading or
trailing whitespace would be compiled incorrectly. Now,
valid HTML with arbitrary whitespace in and surrounding it
can be compiled properly.
@vicb
Copy link
Contributor

vicb commented Aug 13, 2014

Thanks, could you squash all the commits now (git rebase -i master)

ofagbemi added 2 commits August 13, 2014 09:24
feat(TestBed): add whitespace handling to compile
b00bcb3 
Add whitespace handling to the TestBed’s compile function.

Closes #1262. Previously, strings passed with leading or
trailing whitespace would be compiled incorrectly. Now,
valid HTML with arbitrary whitespace in and surrounding it
can be compiled properly.
Merge branch 'master' of https://github.com/ofagbemi/angular.dart
2eb7c4d
@ofagbemi
Copy link
Contributor Author

Okay, I think that should be it. Let me know if I messed up anywhere!

@vicb
Copy link
Contributor

vicb commented Aug 13, 2014

When you send a PR you should create a branch on your repo and sending from this branch.
Sending a PR from you master branch is a bad idea as the PR will get amended will all subsequent commits you push to your master branch.

To fix this you need to open a new PR (you can not change the source branch of a PR).

So:

  • Make sure your repo master is in sync with the master on this repo,
  • Create a "feature branch" by branching off your master,
  • Make sure there is only 1 commit in this branch w/ your update,
  • Push this branch on your repo and create a PR.

@ofagbemi
Copy link
Contributor Author

Okay, sent the new PR in #1346. Very sorry for all the confusion. Thanks!

@ofagbemi ofagbemi closed this Aug 13, 2014
@vicb
Copy link
Contributor

vicb commented Aug 13, 2014

No problem, thanks for taking the time to update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes type: refactoring
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofagbemi @mhevery @vicb