Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

ShadowRootAware should not be defined in lib/core/annotation.dart #1531

Closed
@BlackHC

Description

@BlackHC

ShadowRootAware is a helper interface and not an annotation. Because it is defined in annotation.dart, it pulls dart:html import into annotation.dart as well, which makes it impossible to write non-drt tests for dart components, even though simple components might not require it otherwise.

Moreover, a recent PR #1401 undid PR #1313 that fixed a spurious export (ShadowRootAware from annotation_src.dart) that does not exist anymore.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions