Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

domRead() and domWrite() callbacks are getting called even if the scope was destroyed #1161

Closed
@isoos

Description

@isoos

If the component registers domRead and domWrite callbacks, yet a parent ng-if will wipe out the scope, the callbacks may find an inconsistent state. There are two outcomes here:

  • calling the callbacks may cause exceptions due to the unexpected state
  • not calling the callbacks may leave something else in a hanging state

I'd vote for the not calling (as potentially hanging state seems to be less frequent thing, and it is easy to handle it on a scope destroy at the first place).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions