Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

False positive in collections dccd  #1105

Closed
@vicb

Description

@vicb

[a b c] -> [b a c] would report a move for c

collection: b[1 -> 0], a[0 -> 1], c
previous: a[0 -> 1], b[1 -> 0], c
additions: 
moves: b[1 -> 0], a[0 -> 1], c
removals: 

UT (failing on master):

        it('should not report unnecessary moves', () {
          var list = ['a', 'b', 'c'];
          var record = detector.watch(list, null, null);
          var iterator = detector.collectChanges()..moveNext();

          list..clear()..addAll(['b', 'a', 'c']);
          iterator = detector.collectChanges()..moveNext();
          expect(iterator.current.currentValue, toEqualCollectionRecord(
              collection: ['b[1 -> 0]', 'a[0 -> 1]', 'c'],
              previous: ['a[0 -> 1]', 'b[1 -> 0]', 'c'],
              additions: [],
              moves: ['b[1 -> 0]', 'a[0 -> 1]'],
              removals: []));
        });

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions