Skip to content

grpclib_client: handle trailer-only responses #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2020
Merged

grpclib_client: handle trailer-only responses #127

merged 1 commit into from
Jul 25, 2020

Conversation

abn
Copy link
Collaborator

@abn abn commented Jul 22, 2020

Resolves: #123

@abn abn mentioned this pull request Jul 22, 2020
Closed
boukeversteegh
boukeversteegh approved these changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@boukeversteegh boukeversteegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the fix turned out so simple! Great job and thanks for adding those test-cases too 😄 👍

@boukeversteegh boukeversteegh merged commit 3d8c0cb into danielgtaylor:master Jul 25, 2020
Gobot1234 added a commit to Gobot1234/python-betterproto that referenced this pull request Aug 6, 2020
@Gobot1234
Revert "grpclib_client: handle trailer-only responses (danielgtaylor#127
8f3065b 
)"

This reverts commit 3d8c0cb
Gobot1234 pushed a commit to Gobot1234/python-betterproto that referenced this pull request Aug 24, 2020
@abn @Gobot1234
grpclib_client: handle trailer-only responses (danielgtaylor#127)
6e99e45 
Resolves: danielgtaylor#123
@abn abn deleted the issue/123 branch November 24, 2020 19:40
@abn abn mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boukeversteegh boukeversteegh boukeversteegh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show error responses from grpc server
2 participants
@abn @boukeversteegh