Skip to content

fix: stringify coverage object to improve performance #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix: stringify coverage object to improve performance #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (Cypress.env('coverage') === false) {
const applicationSourceCoverage = win.__coverage__

if (applicationSourceCoverage) {
cy.task('combineCoverage', applicationSourceCoverage)
cy.task('combineCoverage', JSON.stringify(applicationSourceCoverage))
}
})
})
Expand Down Expand Up @@ -54,7 +54,7 @@ if (Cypress.env('coverage') === false) {
// original failed request
return
}
cy.task('combineCoverage', coverage)
cy.task('combineCoverage', JSON.stringify(coverage))
})
}

Expand All @@ -75,7 +75,7 @@ if (Cypress.env('coverage') === false) {
(fileCoverage, filename) =>
filename.startsWith(specFolder) || filename.startsWith(supportFolder)
)
cy.task('combineCoverage', coverage)
cy.task('combineCoverage', JSON.stringify(coverage))
}

// when all tests finish, lets generate the coverage report
Expand Down
8 changes: 7 additions & 1 deletion task.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,14 @@ module.exports = {
/**
* Combines coverage information from single test
* with previously collected coverage.
*
* @param {string} sentCoverage Stringified coverage object sent by the test runner
* @returns {null} Nothing is returned from this task
*/
combineCoverage(coverage) {
combineCoverage(sentCoverage) {
const coverage = JSON.parse(sentCoverage)
debug('parsed sent coverage')

fixSourcePathes(coverage)
const previous = existsSync(nycFilename)
? JSON.parse(readFileSync(nycFilename))
Expand Down