Skip to content

Changes to mimic yaml on Cypress public repo #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

kfb1007
Copy link

@kfb1007 kfb1007 commented Jul 11, 2023

I'm making some suggested changes based on discussion with Snyk support.

Replacing node@master with setup@master which is used the Cypress repo. Using setup@master also requires the additional SNYK TEST command that is added.

@kfb1007 kfb1007 requested a review from brady-cypressio July 11, 2023 19:31
@kfb1007 kfb1007 self-assigned this Jul 11, 2023
@CLAassistant
Copy link

CLAassistant commented Jul 11, 2023

CLA assistant check
All committers have signed the CLA.

@brady-cypressio
Copy link

Note: This was copied from a known good repo, but was not tested. Given that it's currently broken, approving based on known good configs .

@kfb1007 kfb1007 requested a review from lmiller1990 July 11, 2023 21:32
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lmiller1990 lmiller1990 merged commit 161ee05 into master Jul 12, 2023
@lmiller1990 lmiller1990 deleted the kfb1007-patch-1-change-snyk-command branch July 12, 2023 00:10
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants