Skip to content

fix: handling the file placeholder when merging #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 14, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Dec 11, 2020

Before

The first spec covers src/a.js but not src/b.js. Thus the src/b.js has the placeholder info.

$ npm run clean
$ npm run test:a
$ npm run report

Screen Shot 2020-12-14 at 2 50 07 PM

Now run the second test - it should fill the src/b.js right?

$ npm run test:b
$ npm run report

Screen Shot 2020-12-14 at 2 51 13 PM

So it was wrong, since the placeholder did not merge correctly with the information from spec-b

After

$ npm run clean
$ npm run test:a
$ npm run report

Screen Shot 2020-12-14 at 2 52 24 PM

and then run the second spec

$ npm run test:b
$ npm run report

Screen Shot 2020-12-14 at 2 53 08 PM

The HTML report is correct

Screen Shot 2020-12-14 at 2 53 56 PM

@bahmutov bahmutov marked this pull request as ready for review December 14, 2020 20:04
@bahmutov bahmutov merged commit 4f08006 into master Dec 14, 2020
@bahmutov
Copy link
Contributor Author

🎉 This PR is included in version 3.8.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emilyrohrbough emilyrohrbough deleted the work-with-placeholders branch March 22, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage not collected when using async import
1 participant