This repository was archived by the owner on Jun 1, 2020. It is now read-only.
add email widget #68
Merged
add email widget #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Can you update the PR deleting |
agustin107
added
enhancement
|
So do you want a yarn lock file or none? |
|
Yep! We have versioned the |
# Conflicts: # src/TextWidget/TextWidget.tsx
|
ok done @agustin107 |
agustin107
reviewed
Oct 23, 2019
Co-Authored-By: Agustin N. R. Ramirez <agustin107@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the type of an email field is
stringwith formatemailit was not rendering an email field before. You could abstract this either with a factory function or a component that takes the format into consideration and is registered asTextWidgetandEmailWidget. If you prefer another solution I'll happily adapt this PR