Skip to content

Install packaging module if not found #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

raman325
Copy link
Contributor

Resolves #90

@craigbarratt
Copy link
Member

Thanks for quickly looking into and addressing #90.

One question - is it possible to fix via just adding packaging to requirements in custom_components/pyscript/manifest.json?

@raman325
Copy link
Contributor Author

yes, that may be a better approach, and I don't know why I didn't think of that

@raman325
Copy link
Contributor Author

raman325 commented Nov 17, 2020

The only rub there will be that for certain installations of Home Assistant (I know the Docker container for example already has packaging), packaging is already installed, and I'm not clear on whether or not pinning it to a version will break something in the future

@craigbarratt
Copy link
Member

Good point - it looks like requirements in manifest.json is always pinned, which is problematic for the reason you mention. I haven't looked at the code to see whether pinning is required, but it seems risky even if pinning wasn't required since all components I checked do pin.

It does seem like this PR is the best fix.

@craigbarratt craigbarratt merged commit 24abbe8 into custom-components:master Nov 17, 2020
@craigbarratt
Copy link
Member

Thanks!

craigbarratt added a commit that referenced this pull request Nov 17, 2020
@raman325 raman325 deleted the install_packaging branch December 31, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component error: pyscript - No module named 'packaging'
2 participants