Skip to content

Fix pylint error from PR #31 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2020
Merged

Fix pylint error from PR #31 #35

merged 2 commits into from
Oct 11, 2020

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Oct 11, 2020 •
edited
Loading

Should fix #31 (comment)

@raman325
Copy link
Contributor Author

As an aside, it might be a good idea to add pylint as a pre-commit hook

@craigbarratt craigbarratt merged commit cdd6988 into custom-components:master Oct 11, 2020
@craigbarratt
Copy link
Member

Thanks - it's clean now. pylint isn't part of the commit/PR tests; seems a bit onerous to add it. But I do check it from time-to-time.

@raman325 raman325 deleted the fix_pylint branch October 11, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raman325 @craigbarratt