Upgrading pytest-homeassistant-custom-component to 0.0.20

[craigbarratt]

@raman325 - I was looking at upgrading pytest-homeassistant-custom-component from 0.0.8 to 0.0.20. That requires a few other upgrades, including these in tests/requirements_test.txt:

coverage==5.3
pre-commit==2.8.2
pytest==6.1.2

After adding an empty custom_components/__init__.py file (see this issue), all the tests run except tests/test_apps_modules.py which stalls without any error until you hit ^C.

Would you mind seeing what's wrong with tests/test_apps_modules.py?

Once it runs cleanly then I'll update tests/requirements_test.txt.

Thanks!

[raman325]

To be quite honest with you, at first glance I don't see anything wrong. I also looked at the diff between 0.0.8 and 0.0.20 and nothing sticks out: MatthewFlamm/pytest-homeassistant-custom-component@v0.0.8...0.0.20 I will try to look at this again in the upcoming weekend, this week is tough due to Thanksgiving

[balloob]

Run the test suite with pytest --timeout=2 tests and you will see exactly where it was hanging. Common cause for hanging tests is calling a sync method from async context.

[raman325]

Thanks @balloob I am seeing the same exception I saw last night which is an UnknownHandler exception. I don't understand why that's occurring or why it's blocking there - the other test files use the exact same logic to setup the component and they don't seem to have the same issue. In the logs I can also see that HA is loading pyscript - is there some sort of race condition here that I am missing?

https://pastebin.com/GvY6xtLV

[balloob]

Oh, just import the config flow platform before running the test.

[balloob]

This only happens if you don't use the normal way of instantiating a config flow btw.

[raman325]

I tried instantiating a config flow by running hass.config_entries.flow.async_init but hit the same error. Am I missing something?

[craigbarratt]

Thanks @balloob and @raman325! I pushed a change that patches just custom_components.pyscript.global_ctx.open with MockOpen() instead of builtins.open, and the test then passes. As you suggest, there's probably a more robust fix.

Anyhow, I'll go ahead and pin pytest-homeassistant-custom-component to 0.0.20, and update tests/requirements_test.txt.

[raman325]

Ah nevermind, looks like @craigbarratt figured it out. My guess is that your original patch was preventing HA from loading the integration/platforms correctly.

[craigbarratt]

Yes, that makes sense. It was probably the root cause. Sorry to bother you.

[raman325]

All good glad you got it resolved

[balloob]

Home Assistant needs to load manifests etc. Generally, avoid mocking builtins and do what you did here instead 👍