Ensure caches are persisted #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the caches were re-initialized on every plugin initialization. This caused an incompatibility with other tools like rebundler or persistify. This change keeps the original intent of creating caches when the plugin is initialized, but ensures the process keeps the caches instead of the plugin instance itself. It’s not really possible to have a cache conflict since they’re keyed by file.
|
Great to see you got it working with rebundler! |
|
Thanks for the fast merge! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the caches were re-initialized on every plugin initialization.
This caused an incompatibility with other tools like rebundler or
persistify.
This change keeps the original intent of creating caches when the plugin is
initialized, but ensures the process keeps the caches instead of the plugin
instance itself. It’s not really possible to have a cache conflict since
they’re keyed by file.
Fixes #32