Skip to content

Peer deps #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2015
Merged

Peer deps #12

merged 3 commits into from
Aug 9, 2015

Conversation

mightyaleksey
Copy link
Member

No description provided.

@joeybaker
Copy link
Contributor

👍 You'll probably want to also specify these as devDependencies too so the tests will pass :)

@mightyaleksey
Copy link
Member Author

I checked it with npm@3.2.2 and looks like it still installs peerDeps. I also saw your commits in the fork so I assume you had some problems with it?

@joeybaker
Copy link
Contributor

hmmm… no, I didn't actually try it. I just have the habit of putting them in devDeps since they won't be installed in the future. Interesting that it's not a problem.

@mightyaleksey
Copy link
Member Author

Sounds logical :) Let me update it

@mightyaleksey
Copy link
Member Author

Thanks :)

mightyaleksey added a commit that referenced this pull request Aug 9, 2015
@mightyaleksey mightyaleksey merged commit 60916cf into master Aug 9, 2015
@mightyaleksey mightyaleksey deleted the peer-deps branch August 9, 2015 18:58
@joeybaker
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants